Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(graph): equals/not_equals_ignore_case operators (solvers) #3698

Merged
merged 2 commits into from
Oct 23, 2022

Conversation

estergo
Copy link
Contributor

@estergo estergo commented Oct 19, 2022

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Description

Introducing 2 new operators - equal_ignore_case and not_equal_ignore_case operators, that given 2 values, check if those values equal ignore case sensitive.

Fixes # (issue)

New/Edited policies (Delete if not relevant)

Description

Include a description of what makes it a violation and any relevant external links.

Fix

How does someone fix the issue in code and/or in runtime?

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my feature, policy, or fix is effective and works
  • New and existing tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@estergo estergo changed the title feat equal/not_equal_ignore_case operators (solvers) feat(general): equal/not_equal_ignore_case operators (solvers) Oct 19, 2022
Copy link
Contributor

@ChanochShayner ChanochShayner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@gruebel gruebel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

all in all looks great, but please change the name from equal_ignore_case to equals_ignore_case and the not flavour too, so it is more similar to the equals and not_equals operator. It would be great to adjust also the class names and file names. Sorry for the extra work 😅

Copy link
Contributor

@gruebel gruebel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks, great work 🍻

@gruebel gruebel changed the title feat(general): equal/not_equal_ignore_case operators (solvers) feat(graph): equals/not_equals_ignore_case operators (solvers) Oct 23, 2022
@gruebel gruebel merged commit 9aeab2e into master Oct 23, 2022
@gruebel gruebel deleted the equal_ignore_case_operator branch October 23, 2022 15:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants