-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
break(terraform): return UNKNOWN for unrendered values in graph checks #3689
break(terraform): return UNKNOWN for unrendered values in graph checks #3689
Conversation
…d values add None option to complex solvers as well
…om and/or connection solvers
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very nice @YaaraVerner !
Small comments
checkov/common/checks_infra/solvers/attribute_solvers/not_exists_attribute_solver.py
Outdated
Show resolved
Hide resolved
checkov/common/checks_infra/solvers/complex_solvers/and_solver.py
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nice work, a lot to dig through 😄 added a few comments
checkov/common/checks_infra/solvers/attribute_solvers/base_attribute_solver.py
Outdated
Show resolved
Hide resolved
checkov/common/checks_infra/solvers/complex_solvers/base_complex_solver.py
Show resolved
Hide resolved
checkov/common/checks_infra/solvers/connections_solvers/and_connection_solver.py
Show resolved
Hide resolved
checkov/common/checks_infra/solvers/connections_solvers/and_connection_solver.py
Outdated
Show resolved
Hide resolved
Co-authored-by: Anton Grübel <[email protected]>
…ribute_solver.py Co-authored-by: Anton Grübel <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nice, great work 🥇
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
Description
Added
UNKNOWN
graph check result for unrendered attributes.Added a new list of unknown results to the return value of the solvers'
run
function.Changed the return value of
get_operation
function in attribute and complex solvers to Optional[bool], None value will indicateUNKNOWN
check result.Added a new list of unknown results to the return value of the connections solvers'
get_operation
function.Removed the handling of this use case in specific solvers.
Adjusted the solvers' tests to expect
UNKNOWN
results for those use cases.Checklist: