feat(terraform): add CKV NCP rules about Network ACL.

checkov/terraform/checks/resource/ncp/NACLPortCheck.py

@@ -0,0 +1,24 @@
+from checkov.terraform.checks.resource.base_resource_check import BaseResourceCheck
+from checkov.common.models.enums import CheckResult, CheckCategories
+
+
+class NACLPortCheck(BaseResourceCheck):
+    def __init__(self):
+        name = "An inbound Network ACL rule should not allow ALL ports."
+        id = "CKV_NCP_12"
+        supported_resources = ('ncloud_network_acl_rule',)
+        categories = (CheckCategories.NETWORKING,)
+        super().__init__(name=name, id=id, categories=categories, supported_resources=supported_resources)
+
+    def scan_resource_conf(self, conf):
+        if 'inbound' in conf.keys():
+            for inbound in conf['inbound']:
+                if 'port_range' in inbound.keys():
+                    for port_range in inbound['port_range']:
+                        if port_range == "1-65535":
+                            return CheckResult.FAILED
+                    return CheckResult.PASSED
+        return CheckResult.FAILED
+
+
+check = NACLPortCheck()

tests/terraform/checks/resource/ncp/example_NACLPortCheck/main.tf

@@ -0,0 +1,46 @@
+resource "ncloud_network_acl_rule" "pass" {
+  network_acl_no    = ncloud_network_acl.nacl.id
+
+  inbound {
+    priority    = 110
+    protocol    = "TCP"
+    rule_action = "ALLOW"
+    deny_allow_group_no = ncloud_network_acl_deny_allow_group.deny_allow_group.id
+    port_range  = "22"
+  }
+}
+
+resource "ncloud_network_acl_rule" "pass1" {
+  network_acl_no    = ncloud_network_acl.nacl.id
+
+  inbound {
+    priority    = 110
+    protocol    = "TCP"
+    rule_action = "ALLOW"
+    deny_allow_group_no = ncloud_network_acl_deny_allow_group.deny_allow_group.id
+    port_range  = "1-43"
+  }
+}
+
+resource "ncloud_network_acl_rule" "fail" {
+  network_acl_no    = ncloud_network_acl.nacl.id
+
+  inbound {
+    priority    = 110
+    protocol    = "TCP"
+    rule_action = "ALLOW"
+    deny_allow_group_no = ncloud_network_acl_deny_allow_group.deny_allow_group.id
+  }
+}
+
+resource "ncloud_network_acl_rule" "fail1" {
+  network_acl_no    = ncloud_network_acl.nacl.id
+
+  inbound {
+    priority    = 110
+    protocol    = "TCP"
+    rule_action = "ALLOW"
+    deny_allow_group_no = ncloud_network_acl_deny_allow_group.deny_allow_group.id
+    port_range  = "1-65535"
+  }
+}

tests/terraform/checks/resource/ncp/test_NACLPortCheck.py

@@ -0,0 +1,42 @@
+import unittest
+from pathlib import Path
+
+from checkov.runner_filter import RunnerFilter
+from checkov.terraform.checks.resource.ncp.NACLPortCheck import check
+from checkov.terraform.runner import Runner
+
+
+class TestNACLPortCheck(unittest.TestCase):
+    def test(self):
+        # given
+        test_files_dir = Path(__file__).parent / "example_NACLPortCheck"
+
+        # when
+        report = Runner().run(root_folder=str(test_files_dir), runner_filter=RunnerFilter(checks=[check.id]))
+
+        # then
+        summary = report.get_summary()
+
+        passing_resources = {
+            "ncloud_network_acl_rule.pass",
+            "ncloud_network_acl_rule.pass1"
+        }
+        failing_resources = {
+            "ncloud_network_acl_rule.fail",
+            "ncloud_network_acl_rule.fail1"
+        }
+
+        passed_check_resources = {c.resource for c in report.passed_checks}
+        failed_check_resources = {c.resource for c in report.failed_checks}
+
+        self.assertEqual(summary["passed"], 2)
+        self.assertEqual(summary["failed"], 2)
+        self.assertEqual(summary["skipped"], 0)
+        self.assertEqual(summary["parsing_errors"], 0)
+
+        self.assertEqual(passing_resources, passed_check_resources)
+        self.assertEqual(failing_resources, failed_check_resources)
+
+
+if __name__ == "__main__":
+    unittest.main()