Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(terraform): add versioned kubernetes resources to terraform kubernetes checks (5/5) #3657

Merged

Conversation

ugrave
Copy link
Contributor

@ugrave ugrave commented Oct 13, 2022

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Description

This PR adds add the new resource names to the existing checks. PR 5 of 5.

Fixes #3650

Edited policies

  • CKV_K8S_18
    Add resource: kubernetes_pod_v1
  • CKV_K8S_17
    Add resource: kubernetes_pod_v1
  • CKV_K8S_19
    Add resource: kubernetes_pod_v1
  • CKV_K8S_44
    Add resource: kubernetes_service_v1
  • CKV_K8S_49
    Add resources: kubernetes_role_v1, kubernetes_cluster_role_v1

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my feature, policy, or fix is effective and works
  • New and existing tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@ugrave ugrave changed the title Add versioned kubernetes resources to terraform kubernetes checks (5/5) feat(terraform) Add versioned kubernetes resources to terraform kubernetes checks (5/5) Oct 13, 2022
@ugrave ugrave changed the title feat(terraform) Add versioned kubernetes resources to terraform kubernetes checks (5/5) feat(terraform): Add versioned kubernetes resources to terraform kubernetes checks (5/5) Oct 13, 2022
@ugrave ugrave changed the title feat(terraform): Add versioned kubernetes resources to terraform kubernetes checks (5/5) feat(terraform): add versioned kubernetes resources to terraform kubernetes checks (5/5) Oct 13, 2022
@ugrave ugrave force-pushed the versioned_kubernetes_resources_part_5 branch from aaab083 to 0cac859 Compare October 20, 2022 05:31
Copy link
Contributor

@gruebel gruebel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

great work 💯

@nimrodkor nimrodkor merged commit 668e765 into bridgecrewio:master Oct 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Terraform kubernetes checks doesn`t include new versioned resources
3 participants