Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(terraform): add versioned kubernetes resources to terraform kubernetes checks (4/5) #3656

Merged

Conversation

ugrave
Copy link
Contributor

@ugrave ugrave commented Oct 13, 2022

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Description

This PR adds add the new resource names to the existing checks. PR 4 of 5.

Fixes #3650

Edited policies

  • CKV_K8S_37
    Add resource: kubernetes_pod_v1
  • CKV_K8S_29
    Add resources: kubernetes_pod_v1, kubernetes_deployment_v1, kubernetes_daemon_set_v1
  • CKV_K8S_16
    Add resource: kubernetes_pod_v1
  • CKV_K8S_9
    Add resource: kubernetes_pod_v1
  • CKV_K8S_22
    Add resource: kubernetes_pod_v1
  • CKV_K8S_35
    Add resource: kubernetes_pod_v1

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my feature, policy, or fix is effective and works
  • New and existing tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@ugrave ugrave changed the title Add versioned kubernetes resources to terraform kubernetes checks (4/5) feat(terraform) Add versioned kubernetes resources to terraform kubernetes checks (4/5) Oct 13, 2022
@ugrave ugrave changed the title feat(terraform) Add versioned kubernetes resources to terraform kubernetes checks (4/5) feat(terraform): Add versioned kubernetes resources to terraform kubernetes checks (4/5) Oct 13, 2022
@ugrave ugrave changed the title feat(terraform): Add versioned kubernetes resources to terraform kubernetes checks (4/5) feat(terraform): add versioned kubernetes resources to terraform kubernetes checks (4/5) Oct 13, 2022
@ugrave
Copy link
Contributor Author

ugrave commented Oct 18, 2022

Note sure why the PR Test / integration-tests is failing:
ModuleNotFoundError: No module named 'pip'
Some infrastructure problems?

@gruebel
Copy link
Contributor

gruebel commented Oct 19, 2022

yeah kind of, GitHub changed something in their windows runner and this results in an error for Python 3.11. Please just merge master branch into your current one and then it will work again 🙂

@ugrave ugrave force-pushed the versioned_kubernetes_resources_part_4 branch from d0cd9ca to cc35b81 Compare October 19, 2022 10:43
@gruebel gruebel merged commit 57c70ef into bridgecrewio:master Oct 19, 2022
ugrave added a commit to ugrave/checkov that referenced this pull request Oct 20, 2022
…rnetes checks (4/5) (bridgecrewio#3656)

Add versioned kubernetes resources to terraform kubernetes checks (Part 4/5)
@ugrave ugrave deleted the versioned_kubernetes_resources_part_4 branch October 20, 2022 06:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Terraform kubernetes checks doesn`t include new versioned resources
4 participants