Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(terraform): add versioned kubernetes resources to terraform kubernetes checks (2/5) #3654

Merged

Conversation

ugrave
Copy link
Contributor

@ugrave ugrave commented Oct 13, 2022

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Description

This PR adds add the new resource names to the existing checks. PR 2 of 5.

Fixes #3650

Edited policies

  • CKV_K8S_21
    Add resources: kubernetes_pod_v1, kubernetes_deployment_v1, kubernetes_daemon_set_v1, kubernetes_stateful_set_v1, kubernetes_replication_controller_v1, kubernetes_job_v1, kubernetes_cron_job_v1, kubernetes_api_service_v1, kubernetes_secret_v1, kubernetes_service_account_v1, kubernetes_role_binding_v1, kubernetes_config_map_v1, kubernetes_ingress_v1
  • CKV_K8S_41
    Add resources: kubernetes_service_account_v1
  • CKV_K8S_42
    Add resources: kubernetes_role_binding_v1, kubernetes_cluster_role_binding_v1
  • CKV_K8S_27
    Add resources: kubernetes_pod_v1, kubernetes_deployment_v1, kubernetes_daemon_set_v1
  • CKV_K8S_28
    Add resource: kubernetes_pod_v1
  • CKV_K8S_26
    Add resource: kubernetes_pod_v1

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my feature, policy, or fix is effective and works
  • New and existing tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@ugrave ugrave changed the title Add versioned kubernetes resources to terraform kubernetes checks (2/5) feat(terraform) Add versioned kubernetes resources to terraform kubernetes checks (2/5) Oct 13, 2022
@ugrave ugrave changed the title feat(terraform) Add versioned kubernetes resources to terraform kubernetes checks (2/5) feat(terraform): Add versioned kubernetes resources to terraform kubernetes checks (2/5) Oct 13, 2022
@ugrave ugrave changed the title feat(terraform): Add versioned kubernetes resources to terraform kubernetes checks (2/5) feat(terraform): add versioned kubernetes resources to terraform kubernetes checks (2/5) Oct 13, 2022
@ugrave ugrave force-pushed the versioned_kubernetes_resources_part_2 branch from 02ee939 to 33224f8 Compare October 13, 2022 09:00
@ugrave ugrave force-pushed the versioned_kubernetes_resources_part_2 branch from 33224f8 to ab9f1cf Compare October 14, 2022 14:55
Copy link
Contributor

@gruebel gruebel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice job 🍸

@gruebel gruebel merged commit e11a3c4 into bridgecrewio:master Oct 19, 2022
@ugrave ugrave deleted the versioned_kubernetes_resources_part_2 branch October 20, 2022 06:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Terraform kubernetes checks doesn`t include new versioned resources
3 participants