fix(kubernetes): handled missing field secretKeyRef in template #3639
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tronxd
approved these changes
Oct 11, 2022
gruebel
reviewed
Oct 11, 2022
Co-authored-by: Anton Grübel <[email protected]>
gruebel
added a commit
to gruebel/checkov
that referenced
this pull request
Oct 11, 2022
…gecrewio#3639) * handled missing field secretKeyRef in template * Update checkov/kubernetes/checks/resource/k8s/Secrets.py Co-authored-by: Anton Grübel <[email protected]> Co-authored-by: Anton Grübel <[email protected]>
gruebel
added a commit
to gruebel/checkov
that referenced
this pull request
Oct 11, 2022
…gecrewio#3639) * handled missing field secretKeyRef in template * Update checkov/kubernetes/checks/resource/k8s/Secrets.py Co-authored-by: Anton Grübel <[email protected]> Co-authored-by: Anton Grübel <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
Description
handled missing field "secretKeyRef" in k8s secrets template.
No UT for this specific case wasn't added since a YAML with null value is not parsed in checkov (considered as a parsing error)
Checklist: