feat(terraform): add CKV NCP rules about access control group Inbound rule. #3627
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
branch 'master' of https://github.com/init-cloud/checkov
Co-authored-by: Anton Grübel <[email protected]>
Co-authored-by: Anton Grübel <[email protected]>
Co-authored-by: Anton Grübel <[email protected]>
gruebel
reviewed
Oct 14, 2022
checkov/terraform/checks/resource/ncp/AccessControlGroupRuleDescription.py
Outdated
Show resolved
Hide resolved
checkov/terraform/checks/resource/ncp/AccessControlGroupInboundRule.py
Outdated
Show resolved
Hide resolved
checkov/terraform/checks/resource/ncp/AccessControlGroupInboundRule.py
Outdated
Show resolved
Hide resolved
checkov/terraform/checks/resource/ncp/AccessControlGroupInboundRulePort22.py
Outdated
Show resolved
Hide resolved
checkov/terraform/checks/resource/ncp/AccessControlGroupInboundRulePort3389.py
Outdated
Show resolved
Hide resolved
|
Thank you for all advice! I modified this PR! |
nimrodkor
approved these changes
Oct 25, 2022
PelegLi
pushed a commit
that referenced
this pull request
Oct 25, 2022
… rule. (#3627) * [22.09.27][추가] CKV_NCP_1 * [22.09.27][추가] CKV_NCP_2 * Apply suggestions from code review Co-authored-by: Anton Grübel <[email protected]> * Apply suggestions from code review Co-authored-by: Anton Grübel <[email protected]> * Apply suggestions from code review Co-authored-by: Anton Grübel <[email protected]> * Create main.yml * [22.09.28][수정] Lint test * Delete main.yml * [22.09.29][수정]testcode 수정 * [22.09.29][수정] 테스트 코드 수정 * [22.09.29][수정] 테스트코드 수정 * [22.09.29][수정] add test resource for 'ncloud_access_control_group_rule' * [22.10.03][add]CKV_AWS_3 RULE * [22.10.04][add]CKV_NCP_4, CKV_NCP_5 RULE * [22.10.04][add] NCP ACG Inbound for port 22, 3389 * [22.10.04][add] NCP NACL for port 20, 21, 22, 3389 * [22.10.05][modify] LBSecureProtocols.py * [22.10.05][add] NCP ACGIngress & Egress Check * [22.10.06][add] NCP rules about ACG, LB, NACL, Encrpytion * [22.10.06][refactor] rename rules * [22.10.07][add] NCP NACLPortCheck * [22.10.08][refactor] modify rule id 77 to 14 * [22.10.09][refactor] modify for ncp tf rules 4, 5 * [22.10.15][refactor] refactoring acg rule 4, 5 * [22.10.15][refactor] refactoring ncp acg absclass * [22.10.18][fix] ncp rule 2 id fix * [22.10.19][refactor] adjust ncp rule 4, 5 Co-authored-by: pj991207 <[email protected]> Co-authored-by: Anton Grübel <[email protected]> Co-authored-by: taeng0204 <[email protected]> Co-authored-by: yudam <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
Description
Add terraform scan rules about provider Naver Cloud Platform.
CKV_NCP_4, 5 is associated with Access Control Group Inbound Rule.
This rule suggests no access control groups allow inbound from 0.0.0.0 to port 22 and 3389.
Description
https://registry.terraform.io/providers/NaverCloudPlatform/ncloud/latest/docs/resources/access_control_group_rule
Checklist: