platform(general): Get resources from platform and filter taggable resources for policies #3621
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…esources (not all)
mikeurbanski1
changed the title
|
I am in typing hell |
tronxd
approved these changes
Oct 27, 2022
checkov/common/bridgecrew/integration_features/features/attribute_resource_types_integration.py
Outdated
Show resolved
Hide resolved
checkov/common/bridgecrew/integration_features/features/attribute_resource_types_integration.py
Outdated
Show resolved
Hide resolved
checkov/common/bridgecrew/integration_features/features/attribute_resource_types_integration.py
Show resolved
Hide resolved
checkov/common/checks_infra/solvers/attribute_solvers/base_attribute_solver.py
Outdated
Show resolved
Hide resolved
|
@gruebel @nimrodkor @rotemavni added you to sanity check whether this can be safely merged. I ran some tests against prod (where the platform changes do not exist) and it seems to work fine in checkov. And I don't think anything here will break a platform scan in the checkov wrapper. |
gruebel
approved these changes
Oct 28, 2022
PelegLi
pushed a commit
that referenced
this pull request
Oct 30, 2022
…sources for policies (#3621) * get attributes from the platform that should be applied to specific resources (not all) * use a set for the taggable resource types * add test of full policy scan * fix tests * remove local resource types * cleanup comments and code * remove unused imports * fix mypy? * fix mypy! * make resource types list or set * make resource types list or set * change resource types to set * resource types as list * handle custom policies injected by platform * save provider to resource mapping * add abstract method shells * mypy * add unique orders for integrations * resolve review comments * fix test
PelegLi
pushed a commit
that referenced
this pull request
Oct 30, 2022
…sources for policies (#3621) * get attributes from the platform that should be applied to specific resources (not all) * use a set for the taggable resource types * add test of full policy scan * fix tests * remove local resource types * cleanup comments and code * remove unused imports * fix mypy? * fix mypy! * make resource types list or set * make resource types list or set * change resource types to set * resource types as list * handle custom policies injected by platform * save provider to resource mapping * add abstract method shells * mypy * add unique orders for integrations * resolve review comments * fix test
PelegLi
pushed a commit
that referenced
this pull request
Oct 30, 2022
…sources for policies (#3621) * get attributes from the platform that should be applied to specific resources (not all) * use a set for the taggable resource types * add test of full policy scan * fix tests * remove local resource types * cleanup comments and code * remove unused imports * fix mypy? * fix mypy! * make resource types list or set * make resource types list or set * change resource types to set * resource types as list * handle custom policies injected by platform * save provider to resource mapping * add abstract method shells * mypy * add unique orders for integrations * resolve review comments * fix test
PelegLi
pushed a commit
that referenced
this pull request
Oct 30, 2022
…sources for policies (#3621) * get attributes from the platform that should be applied to specific resources (not all) * use a set for the taggable resource types * add test of full policy scan * fix tests * remove local resource types * cleanup comments and code * remove unused imports * fix mypy? * fix mypy! * make resource types list or set * make resource types list or set * change resource types to set * resource types as list * handle custom policies injected by platform * save provider to resource mapping * add abstract method shells * mypy * add unique orders for integrations * resolve review comments * fix test
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
Description
So, for example, if you have a platform policy with provider
awsand a condition that checkstagswith resource typesall, then the check will only apply to taggable AWS Terraform resources. If you use the attributeTags.*.Key, then it will only apply to CloudFormation.If you have a Checkov policy that uses
allwith the attributetags, then it will apply it to AWS, Azure, and Ali (because checkov policies do not have a provider in the spec).This also removes the local list of resource types from checkov, which was pretty much totally dead code in reality, because platform custom policies didn't even have the provider in the API response.
Requires some platform changes (some done, some in progress) before this can be 100% safely merged (but it should still work)
Checklist: