fix(terraform): Outdated check for google_container_cluster binary authorization #3612
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gruebel
reviewed
Oct 4, 2022
checkov/terraform/checks/resource/gcp/GKEBinaryAuthorization.py
Outdated
Show resolved
Hide resolved
|
@gruebel do I need to reach out to someone else for another approve review? |
|
hey @losisin sadly you need to wait a bit, because my colleagues have now a couple of holidays 🏖️ but when they are back, I will grab some to review your PR 💪 |
tronxd
approved these changes
Oct 11, 2022
|
@losisin tried to fix the merge conflict, but I have no permission to push my change to your branch |
…ation # Conflicts: # checkov/terraform/checks/resource/gcp/GKEBinaryAuthorization.py
|
@gruebel I resolved the conflict and did |
gruebel
pushed a commit
to gruebel/checkov
that referenced
this pull request
Oct 14, 2022
…thorization (bridgecrewio#3612) * fix deprecation in binary authorization * cleanup a bit * add suggested changes from code review * EOF
gruebel
pushed a commit
to gruebel/checkov
that referenced
this pull request
Oct 14, 2022
…thorization (bridgecrewio#3612) * fix deprecation in binary authorization * cleanup a bit * add suggested changes from code review * EOF
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
Description
This PR tries to cover all cases how binary authorization can be enabled for
google_container_clusterin different version of google provider plugin. Hopefully .... :)Fixes #3409
Checklist: