Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(terraform): fix port is bool ingress rule #3606

Merged
merged 3 commits into from
Oct 3, 2022
Merged

fix(terraform): fix port is bool ingress rule #3606

merged 3 commits into from
Oct 3, 2022

Conversation

achiar99
Copy link
Contributor

@achiar99 achiar99 commented Oct 3, 2022 •
edited
Loading

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Description

Fix sub rule is not dict ingress check

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my feature, policy, or fix is effective and works
  • New and existing tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@achiar99 achiar99 changed the title fix(terraform) - fix port is bool ingress rule fix(terraform): fix port is bool ingress rule Oct 3, 2022
@achiar99 achiar99 merged commit 18fea5e into master Oct 3, 2022
@achiar99 achiar99 deleted the fix-port-bool-ingress branch October 3, 2022 07:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rotemavni rotemavni rotemavni approved these changes

@PelegLi PelegLi PelegLi approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@achiar99 @PelegLi @rotemavni