Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(sca): support Image referencer in CLI #3601

Merged
merged 16 commits into from
Oct 3, 2022

Conversation

arielkru
Copy link
Contributor

@arielkru arielkru commented Oct 2, 2022

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Description

  • On every CLI scan with image referencer results, checkov would now always create the image cached results reports so we can save the results in the platform.
  • For that reason the variable CHECKOV_CREATE_IMAGE_CACHED_REPORTS_FOR_IR is not needed anymore (always true), henced removed from the tests.
  • Whenever the variable was true we were calling the cache twice, so I reduced it to one call and then the result is passed as a variable to the two relevant functions

Fixes # (issue)

New/Edited policies (Delete if not relevant)

Description

Include a description of what makes it a violation and any relevant external links.

Fix

How does someone fix the issue in code and/or in runtime?

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my feature, policy, or fix is effective and works
  • New and existing tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@arielkru arielkru changed the title feat(SCA): support Image referencer in CLI feat(sca): support Image referencer in CLI Oct 2, 2022
@arielkru arielkru marked this pull request as ready for review October 3, 2022 01:03
Copy link
Contributor

@gruebel gruebel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯

@arielkru arielkru merged commit d0ae25c into master Oct 3, 2022
@arielkru arielkru deleted the cli-persist-image-referencer branch October 3, 2022 10:10
itai1357 pushed a commit that referenced this pull request Oct 3, 2022
* add image cached results & other modifications

* fix file prefix

* linting

* linting

* linting

* linting

* linting

* typing

* call cache only once

* update tests

* typing

* typing

* fix conflicts
itai1357 pushed a commit that referenced this pull request Oct 3, 2022
* add image cached results & other modifications

* fix file prefix

* linting

* linting

* linting

* linting

* linting

* typing

* call cache only once

* update tests

* typing

* typing

* fix conflicts
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants