Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(cloudformation): fix lc ebs encryption #3598

Merged
merged 5 commits into from
Oct 2, 2022
Merged

fix(cloudformation): fix lc ebs encryption #3598

merged 5 commits into from
Oct 2, 2022

Conversation

achiar99
Copy link
Contributor

@achiar99 achiar99 commented Oct 2, 2022 •
edited
Loading

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Description

Fix edge case fox cfn lc ebs encryption

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my feature, policy, or fix is effective and works
  • New and existing tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

gruebel
gruebel approved these changes Oct 2, 2022
View reviewed changes
Copy link
Contributor

@gruebel gruebel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you also add the failing CFN template as test case or is to so broken that it dosn't make sense 😄

@achiar99 achiar99 merged commit 0e7a50b into master Oct 2, 2022
@achiar99 achiar99 deleted the fix-lc-ebs-encryption branch October 2, 2022 11:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ChanochShayner ChanochShayner ChanochShayner approved these changes

@gruebel gruebel gruebel approved these changes

@tronxd tronxd tronxd approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@achiar99 @tronxd @gruebel @ChanochShayner