Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(secrets): Skip secrets from files encoded with special codecs #3597

Merged
merged 1 commit into from
Oct 2, 2022

Conversation

nimrodkor
Copy link
Contributor

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Description

We got some errors when scanning files with weird, ascii based codecs on non-human-readable files. No need to scan these as it won't help developers not include it in their READABLE files. This skips the file if the codec is bad.

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my feature, policy, or fix is effective and works
  • New and existing tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@nimrodkor nimrodkor changed the title Skip secrets from files encoded with special codecs fix(secrets): Skip secrets from files encoded with special codecs Oct 2, 2022
@nimrodkor nimrodkor merged commit f3a6970 into master Oct 2, 2022
@nimrodkor nimrodkor deleted the skip_weird_encoding branch October 2, 2022 06:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants