Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(general): allow file destination mapping via output-file-path flag #3593

Merged
merged 2 commits into from
Oct 4, 2022
Merged

feat(general): allow file destination mapping via output-file-path flag #3593

merged 2 commits into from
Oct 4, 2022

Conversation

gruebel
Copy link
Contributor

@gruebel gruebel commented Sep 30, 2022 •
edited
Loading

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Description

  • added the possibility to define a file mapping via --output-file-path flag
  • also fixed an issue when someone chose a path with folder, which don't exist. They will now be created before saving the output to the file

Fixes #3341

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my feature, policy, or fix is effective and works
  • New and existing tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@tsmithv11
Copy link
Collaborator

Great work! Glad you kept the defaults for SARIF and the other outputs.

tsmithv11
tsmithv11 approved these changes Oct 3, 2022
View reviewed changes
Copy link
Collaborator

@tsmithv11 tsmithv11 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🍰

@gruebel
Merge remote-tracking branch 'origin/master' into extend-output-path-…
ef88d38 
…flag

# Conflicts:
#	tests/common/runner_registry/test_runner_registry.py
@fproulx-boostsecurity
Copy link

fproulx-boostsecurity commented Oct 3, 2022 •
edited
Loading

Yay! I hate so much that checkov writes file in my checked out directory.
Especially for SARIF.
Great contribution.
Hoping this will be merged soon.

kartikp10
kartikp10 approved these changes Oct 4, 2022
View reviewed changes
Copy link
Contributor

@kartikp10 kartikp10 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 🚀

@gruebel gruebel merged commit 11edf57 into bridgecrewio:master Oct 4, 2022
@gruebel gruebel deleted the extend-output-path-flag branch October 4, 2022 16:45
gruebel added a commit to gruebel/checkov that referenced this pull request Oct 4, 2022
@gruebel @schosterbarak
feat(general): allow file destination mapping via output-file-path fl…
f1bcc09 
…ag (bridgecrewio#3593)

allow file destination mapping via output-file-path flag
gruebel added a commit to gruebel/checkov that referenced this pull request Oct 4, 2022
@gruebel
feat(general): allow file destination mapping via output-file-path fl…
4595b0a 
…ag (bridgecrewio#3593)

allow file destination mapping via output-file-path flag
@gruebel gruebel mentioned this pull request Oct 5, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tsmithv11 tsmithv11 tsmithv11 approved these changes

@kartikp10 kartikp10 kartikp10 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Allow specifying the output file name
4 participants
@gruebel @tsmithv11 @fproulx-boostsecurity @kartikp10