fix(github): changed the schema to accept no description for org #3589
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gruebel
approved these changes
Sep 30, 2022
| assert result | ||
| result1 = dal.get_organization_security() | ||
|
|
||
| mock_data2 = { |
There was a problem hiding this comment.
can you create a separate test function for this case and name it accordingly, something like test_org_security with_empty_ description.
There was a problem hiding this comment.
thanks :) changed it!
maxamel
approved these changes
Oct 2, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
Description
Update of organization schema for GitHub.
Description
In GitHub, the organization security schema had a description field set to match a string although None is a legal value too.
This caused the data returned from the GitHub API to mismatch the schema in this case, and hence no github_conf file for org security was created. In this case checks CKV_GITHUB_1-3 were skipped.
Fix
Change the schema to match both.
Checklist: