fix(github): fix variables initialization #3585
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marynaKK
force-pushed
the
bug-fix-gihub-dal
branch
from
9836e1c to
c3bae90
Compare
gruebel
reviewed
Sep 29, 2022
| self.github_conf_dir_path = "" | ||
| self.github_org_security_file_path = "" | ||
| self.github_branch_protection_rules_file_path = "" | ||
| self.github_org_webhooks_file_path = "" | ||
| self.github_repository_webhooks_file_path = "" | ||
| self.github_repository_collaborators_file_path = "" | ||
| super().__init__() |
There was a problem hiding this comment.
can you add a comment the init has to be at the end and also add or extend an existing UT to check some/all attributes are filled with something?
There was a problem hiding this comment.
Hi! thanks for the review :) I've added a test for this (all paths should be initialized even if not used)
Also, I moved the type declaration (by Nimrod's suggestion) to be in the class instead of the init method.
💪 🐶
maxamel
approved these changes
Sep 29, 2022
pull bot
pushed a commit
to Mu-L/checkov
that referenced
this pull request
Sep 29, 2022
* vairables nulled after they are initiallized * vairables nulled after they are initiallized * changes to proper str typing in class * fis lint
gruebel
pushed a commit
to gruebel/checkov
that referenced
this pull request
Sep 29, 2022
* vairables nulled after they are initiallized * vairables nulled after they are initiallized * changes to proper str typing in class * fis lint
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
Description
The initialization of the variables in the init of GitHub class is done before the type is set to string (by assigning the "" string). This caused to no checks at all from the GitHub framework (as no repo/account/rtc. are set in the first place)
Checklist: