Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(terraform): fix external modules ids in graph report #3584

Merged
merged 3 commits into from
Sep 29, 2022
Merged

fix(terraform): fix external modules ids in graph report #3584

merged 3 commits into from
Sep 29, 2022

Conversation

YaaraVerner
Copy link
Contributor

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Description

fix external module resources ids in the graph report to contain the referrer id (module.[module_name]) as a prefix.

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my feature, policy, or fix is effective and works
  • New and existing tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@YaaraVerner YaaraVerner changed the title fix: fix external modules ids in graph report fix(terraform): fix external modules ids in graph report Sep 29, 2022
@YaaraVerner YaaraVerner marked this pull request as ready for review September 29, 2022 10:48
@YaaraVerner YaaraVerner merged commit 61d8bbd into master Sep 29, 2022
@YaaraVerner YaaraVerner deleted the add-referrer-id-in-graph-report branch September 29, 2022 10:55
gruebel pushed a commit to gruebel/checkov that referenced this pull request Sep 29, 2022
@YaaraVerner @schosterbarak
fix(terraform): fix external modules ids in graph report (bridgecrewi…
01ff92f 
…o#3584)

* save referrer id in graph report records

* fix getting breadcrumbs

* add test
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ChanochShayner ChanochShayner ChanochShayner approved these changes

@achiar99 achiar99 achiar99 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@YaaraVerner @achiar99 @ChanochShayner