-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(terraform): Added new Terraform-AWS python IAMUserNotUsedForAccess(CKV_AWS_273) policy #3574
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gruebel
reviewed
Sep 28, 2022
checkov/terraform/checks/resource/aws/IAMUserNotUsedForAccess.py
Outdated
Show resolved
Hide resolved
checkov/terraform/checks/resource/aws/IAMUserNotUsedForAccess.py
Outdated
Show resolved
Hide resolved
gruebel
reviewed
Oct 10, 2022
checkov/terraform/checks/resource/aws/IAMUserNotUsedForAccess.py
Outdated
Show resolved
Hide resolved
gruebel
changed the title
feat(terraform): Added new Terraform-AWS python IAMUserNotUsedForAccess(CKV_AWS_272) policy
feat(terraform): Added new Terraform-AWS python IAMUserNotUsedForAccess(CKV_AWS_273) policy
Oct 10, 2022
gruebel
approved these changes
Oct 10, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks for the contribution 💪
NoaAzoulay
approved these changes
Oct 11, 2022
tronxd
approved these changes
Oct 11, 2022
AdamDev
approved these changes
Oct 11, 2022
The merging is blocked for this. Can someone please help take a look? |
tsmithv11
reviewed
Oct 11, 2022
checkov/terraform/checks/resource/aws/IAMUserNotUsedForAccess.py
Outdated
Show resolved
Hide resolved
losisin
pushed a commit
to ignite-analytics/checkov
that referenced
this pull request
Oct 12, 2022
…ss(CKV_AWS_273) policy (bridgecrewio#3574) * Added new aws terraform IAMUserNotUsedForAccess python policy * Updated ckv_aws_273 with comment from previous pull request * fix supported_resources value * adjust the check to fail when aws_iam_user resource found * updated the name for IAMUserNotUsedForAccess.py Co-authored-by: Anton Grübel <[email protected]>
losisin
pushed a commit
to ignite-analytics/checkov
that referenced
this pull request
Oct 12, 2022
…ss(CKV_AWS_273) policy (bridgecrewio#3574) * Added new aws terraform IAMUserNotUsedForAccess python policy * Updated ckv_aws_273 with comment from previous pull request * fix supported_resources value * adjust the check to fail when aws_iam_user resource found * updated the name for IAMUserNotUsedForAccess.py Co-authored-by: Anton Grübel <[email protected]>
losisin
pushed a commit
to ignite-analytics/checkov
that referenced
this pull request
Oct 12, 2022
…ss(CKV_AWS_273) policy (bridgecrewio#3574) * Added new aws terraform IAMUserNotUsedForAccess python policy * Updated ckv_aws_273 with comment from previous pull request * fix supported_resources value * adjust the check to fail when aws_iam_user resource found * updated the name for IAMUserNotUsedForAccess.py Co-authored-by: Anton Grübel <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
Description
This is a check to be in line with AWS security best practices to “ensure IAM users are not defined”
AWS Access should be controlled by roles via an SSO, inline with AWS best practice. Require human users to use federation with an identity provider to access AWS using temporary credentials.
Checklist: