feat(terraform): add CKV_NCP_1 about lb target group health check, CKV_NCP_2 about access control group description #3569

Floodnut · 2022-09-27T06:07:36Z

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Description

Add new terraform provider Naver Cloud Platform.
-- CKV_NCP_1 is associated with Loadbalancing target group's health check.
-- CKV_NCP_2 is associated with Access Control Group Description.

Description

https://registry.terraform.io/providers/NaverCloudPlatform/ncloud/latest/docs/resources/lb_target_group
https://registry.terraform.io/providers/NaverCloudPlatform/ncloud/latest/docs/resources/access_control_group

Checklist:

My code follows the style guidelines of this project
I have performed a self-review of my own code
I have commented my code, particularly in hard-to-understand areas
I have made corresponding changes to the documentation
I have added tests that prove my feature, policy, or fix is effective and works
New and existing tests pass locally with my changes
Any dependent changes have been merged and published in downstream modules

branch 'master' of https://github.com/init-cloud/checkov

gruebel

nice job 🥇 , can you adjust the tests to have dedicated TF files and a test file to simulate an actual run. You can check this PR on how it should look like. If you have problems, let me know, then I can help you out 🙂

checkov/terraform/checks/resource/ncp/__init__.py

checkov/terraform/checks/resource/ncp/AccessControlGroupRuleDescription.py

Co-authored-by: Anton Grübel <[email protected]>

pj991207 · 2022-09-27T10:48:07Z

n you adjust the tests to have dedicated TF files and a test file to simulate an actual run.

did you say that making test code like this snapshot?

pj991207 · 2022-09-27T10:53:00Z

that making test code like this snapshot?

I made a test code like that

gruebel · 2022-09-28T09:27:06Z

n you adjust the tests to have dedicated TF files and a test file to simulate an actual run.

did you say that making test code like this snapshot?

yeah correct. how you wrote the tests is the old way of doing it and it resulted in some issues we had. New tests should use the style I described and over time we update the old tests to fit the newer style.

Floodnut · 2022-09-29T09:05:30Z

We change our test codes with CONTRIBUTING.md styles.
Can you check we commited and what we missed?
thx.

gruebel

thanks looks great. would be nice, if you can the mentioned resource to be tested too 🙂

gruebel · 2022-09-29T10:58:56Z

tests/terraform/checks/resource/ncp/example_AccessControlGroupRuleDescription/main.tf

@@ -0,0 +1,10 @@
+resource "ncloud_access_control_group" "pass" {


can you also add a passing + failing resource for ncloud_access_control_group_rule

I'll check additional resource ncloud_access_control_group_rule!! thanks!

I add resource ncloud_access_control_group_rule !

And Does resources to be tested mean what we commited?

gruebel

great work 🍻

…V_NCP_2 about access control group description (bridgecrewio#3569) * [22.09.27][추가] CKV_NCP_1 * [22.09.27][추가] CKV_NCP_2 * Apply suggestions from code review Co-authored-by: Anton Grübel <[email protected]> * Apply suggestions from code review Co-authored-by: Anton Grübel <[email protected]> * Apply suggestions from code review Co-authored-by: Anton Grübel <[email protected]> * Create main.yml * [22.09.28][수정] Lint test * Delete main.yml * [22.09.29][수정]testcode 수정 * [22.09.29][수정] 테스트 코드 수정 * [22.09.29][수정] 테스트코드 수정 * [22.09.29][수정] add test resource for 'ncloud_access_control_group_rule' Co-authored-by: pj991207 <[email protected]> Co-authored-by: Anton Grübel <[email protected]>

pj991207 and others added 3 commits September 27, 2022 14:52

[22.09.27][추가] CKV_NCP_1

5afbd24

[22.09.27][추가] CKV_NCP_2

4d48fe1

[22.09.27][Merge]

9011d54

branch 'master' of https://github.com/init-cloud/checkov

gruebel changed the title ~~feat(terraform): add CKV_NCP_1 about NCP lb target group health check, CKV_NCP_2 about acccess control group description~~ feat(terraform): add CKV_NCP_1 about lb target group health check, CKV_NCP_2 about access control group description Sep 27, 2022

gruebel changed the title ~~feat(terraform): add CKV_NCP_1 about lb target group health check, CKV_NCP_2 about access control group description~~ feat(terraform): add CKV_NCP_1 about lb target group health check, CKV_NCP_2 about access control group description Sep 27, 2022

gruebel reviewed Sep 27, 2022

View reviewed changes

pj991207 and others added 3 commits September 27, 2022 19:33

Apply suggestions from code review

ea829d9

Co-authored-by: Anton Grübel <[email protected]>

Apply suggestions from code review

0e76a1f

Co-authored-by: Anton Grübel <[email protected]>

Apply suggestions from code review

5150177

Co-authored-by: Anton Grübel <[email protected]>

pj991207 and others added 4 commits September 28, 2022 19:12

Create main.yml

d2b322f

[22.09.28][수정] Lint test

a7e3000

Merge branch 'master' of https://github.com/init-cloud/checkov

2f7dcdf

Delete main.yml

f8e7357

Floodnut changed the title ~~feat(terraform): add CKV_NCP_1 about lb target group health check, CKV_NCP_2 about access control group description~~ feat(terraform): add CKV_NCP_1 about lb target group health check, CKV_NCP_2 about access control group description Sep 28, 2022

pj991207 and others added 4 commits September 29, 2022 00:56

[22.09.29][수정]testcode 수정

52cb35d

[22.09.29][수정] 테스트 코드 수정

b1555cb

[22.09.29][수정] 테스트코드 수정

e77773d

Merge branch 'master' into master

51d2b71

gruebel reviewed Sep 29, 2022

View reviewed changes

Floodnut added 2 commits September 29, 2022 23:41

[22.09.29][수정] add test resource for 'ncloud_access_control_group_rule'

1ccffed

Merge branch 'master' of https://github.com/init-cloud/checkov

49fb76a

gruebel approved these changes Sep 30, 2022

View reviewed changes

Saarett approved these changes Oct 2, 2022

View reviewed changes

gruebel merged commit 71a4d22 into bridgecrewio:master Oct 2, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat(terraform): add CKV_NCP_1 about lb target group health check, CKV_NCP_2 about access control group description #3569

feat(terraform): add CKV_NCP_1 about lb target group health check, CKV_NCP_2 about access control group description #3569

Floodnut commented Sep 27, 2022 •

edited

Loading

gruebel left a comment

pj991207 commented Sep 27, 2022

pj991207 commented Sep 27, 2022

gruebel commented Sep 28, 2022

Floodnut commented Sep 29, 2022

gruebel left a comment

gruebel Sep 29, 2022

Floodnut Sep 29, 2022

Floodnut Sep 29, 2022

gruebel left a comment

		@@ -0,0 +1,10 @@
		resource "ncloud_access_control_group" "pass" {

feat(terraform): add CKV_NCP_1 about lb target group health check, CKV_NCP_2 about access control group description #3569

feat(terraform): add CKV_NCP_1 about lb target group health check, CKV_NCP_2 about access control group description #3569

Conversation

Floodnut commented Sep 27, 2022 • edited Loading

Description

Description

Checklist:

gruebel left a comment

Choose a reason for hiding this comment

pj991207 commented Sep 27, 2022

pj991207 commented Sep 27, 2022

gruebel commented Sep 28, 2022

Floodnut commented Sep 29, 2022

gruebel left a comment

Choose a reason for hiding this comment

gruebel Sep 29, 2022

Choose a reason for hiding this comment

Floodnut Sep 29, 2022

Choose a reason for hiding this comment

Floodnut Sep 29, 2022

Choose a reason for hiding this comment

gruebel left a comment

Choose a reason for hiding this comment

Floodnut commented Sep 27, 2022 •

edited

Loading