feat(terraform): add CKV_AWS_272 to validate Lambda function code-signing #3556
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AdamDev
changed the title
AdamDev
changed the title
gruebel
reviewed
Sep 22, 2022
checkov/terraform/checks/resource/aws/LambdaCodeSigningConfigured.py
Outdated
Show resolved
Hide resolved
checkov/terraform/checks/resource/aws/LambdaCodeSigningConfigured.py
Outdated
Show resolved
Hide resolved
| from checkov.common.models.enums import CheckResult | ||
|
|
||
|
|
||
| class TestLambdaCodeSigningConfigured(unittest.TestCase): |
There was a problem hiding this comment.
you used the wrong style for running the tests, please do something similar like here https://github.com/bridgecrewio/checkov/blob/master/tests/terraform/checks/resource/aws/test_WAFACLCVE202144228.py
gruebel
changed the title
…red.py Co-authored-by: Anton Grübel <[email protected]>
|
Great work! Can you add a description of what the policy is checking for and how to fix a violation of the policy? |
…red.py Co-authored-by: Anton Grübel <[email protected]>
|
@tsmithv11 where do you want to add this description? |
In the Description of the PR. Just add more detail on what the policy is checking for and why a user should turn on code signing verification. |
|
Does this description is ok? |
tsmithv11
approved these changes
Sep 27, 2022
losisin
pushed a commit
to ignite-analytics/checkov
that referenced
this pull request
Sep 28, 2022
…ning (bridgecrewio#3556) * Add check for lambda code_signing_config_arn * set the code of the check * Update checkov/terraform/checks/resource/aws/LambdaCodeSigningConfigured.py Co-authored-by: Anton Grübel <[email protected]> * Update checkov/terraform/checks/resource/aws/LambdaCodeSigningConfigured.py Co-authored-by: Anton Grübel <[email protected]> * change test to the new style Co-authored-by: Adam Varsano <[email protected]> Co-authored-by: Anton Grübel <[email protected]>
losisin
pushed a commit
to ignite-analytics/checkov
that referenced
this pull request
Sep 28, 2022
…ning (bridgecrewio#3556) * Add check for lambda code_signing_config_arn * set the code of the check * Update checkov/terraform/checks/resource/aws/LambdaCodeSigningConfigured.py Co-authored-by: Anton Grübel <[email protected]> * Update checkov/terraform/checks/resource/aws/LambdaCodeSigningConfigured.py Co-authored-by: Anton Grübel <[email protected]> * change test to the new style Co-authored-by: Adam Varsano <[email protected]> Co-authored-by: Anton Grübel <[email protected]>
|
Consider adding switch for image based functions. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
Description
Validate CKV_AWS_272 to check that lambda resource has code_signing_config_arn.
A code-signing configuration includes a set of signing profiles, which define the trusted publishers for this function.
Fix
Optimised CKV_AWS_272 to check that lambda resource has code_signing_config_arn
Checklist: