Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(secrets): Bump bc-detect-secrets #3555

Merged
merged 3 commits into from
Sep 22, 2022
Merged

fix(secrets): Bump bc-detect-secrets #3555

merged 3 commits into from
Sep 22, 2022

Conversation

nimrodkor
Copy link
Contributor

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Description

Bump bc-detect-secrets to fix filtering of regex-based filters with id in them

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my feature, policy, or fix is effective and works
  • New and existing tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@nimrodkor nimrodkor changed the title Bump bc-detect-secrets fix(secrets): Bump bc-detect-secrets Sep 22, 2022
gruebel
gruebel approved these changes Sep 22, 2022
View reviewed changes
Copy link
Contributor

@gruebel gruebel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you also need to adjust the setup.py 🙂

@nimrodkor nimrodkor merged commit 3943017 into master Sep 22, 2022
@nimrodkor nimrodkor deleted the bump_bc_detect_secrets branch September 22, 2022 09:17
tplisson pushed a commit to tplisson/checkov that referenced this pull request Sep 23, 2022
@nimrodkor @schosterbarak
fix(secrets): Bump bc-detect-secrets (bridgecrewio#3555)
718b7e3 
* Bump bc-detect-secrets

* Bump bc-detect-secrets in setup.py

* Fix UTs
tplisson pushed a commit to tplisson/checkov that referenced this pull request Sep 23, 2022
@nimrodkor
fix(secrets): Bump bc-detect-secrets (bridgecrewio#3555)
f7ad8f9 
* Bump bc-detect-secrets

* Bump bc-detect-secrets in setup.py

* Fix UTs
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marynaKK marynaKK marynaKK approved these changes

@gruebel gruebel gruebel approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@nimrodkor @gruebel @marynaKK