Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(kubernetes): create complex k8s vertices #3549

Merged
merged 7 commits into from
Sep 21, 2022
Merged

feat(kubernetes): create complex k8s vertices #3549

merged 7 commits into from
Sep 21, 2022

Conversation

achiar99
Copy link
Contributor

@achiar99 achiar99 commented Sep 21, 2022 •
edited
Loading

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Description

Extract k8s pods resources and create vertices with the metadata for edges

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my feature, policy, or fix is effective and works
  • New and existing tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

PelegLi
PelegLi approved these changes Sep 21, 2022
View reviewed changes
Copy link
Contributor

@PelegLi PelegLi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great!

checkov/kubernetes/graph_builder/local_graph.py Outdated Show resolved Hide resolved
checkov/kubernetes/graph_builder/local_graph.py Outdated Show resolved Hide resolved
checkov/kubernetes/graph_builder/local_graph.py Outdated Show resolved Hide resolved
checkov/kubernetes/kubernetes_utils.py Outdated Show resolved Hide resolved
checkov/kubernetes/graph_builder/local_graph.py Outdated Show resolved Hide resolved
checkov/kubernetes/kubernetes_utils.py Outdated Show resolved Hide resolved
@achiar99 achiar99 merged commit 4bf7fc6 into master Sep 21, 2022
@achiar99 achiar99 deleted the create-complex-k8s-vertices branch September 21, 2022 12:34
gruebel pushed a commit to gruebel/checkov that referenced this pull request Sep 21, 2022
@achiar99 @schosterbarak
feat(kubernetes): create complex k8s vertices (bridgecrewio#3549)
5d9a335 
* create complex k8s vertices

* eof

* lint

* fix more cases

* create block metadata condition

* line

* pr comments
gruebel pushed a commit to gruebel/checkov that referenced this pull request Sep 21, 2022
@achiar99 @schosterbarak
feat(kubernetes): create complex k8s vertices (bridgecrewio#3549)
4042db0 
* create complex k8s vertices

* eof

* lint

* fix more cases

* create block metadata condition

* line

* pr comments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tronxd tronxd tronxd approved these changes

@PelegLi PelegLi PelegLi approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@achiar99 @PelegLi @tronxd