Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(openapi): add CKV_OPENAPI_7 to ensure http is not used in path definition #3547

Merged
merged 3 commits into from
Sep 28, 2022
Merged

feat(openapi): add CKV_OPENAPI_7 to ensure http is not used in path definition #3547

merged 3 commits into from
Sep 28, 2022

Conversation

marynaKK
Copy link
Contributor

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Description

Added a new check to ensure 'http', which is not encrypted, is not used in path definition.
This check is only relevant for v2.

Fixes #3205

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my feature, policy, or fix is effective and works
  • New and existing tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@gruebel gruebel changed the title feat(openAPI) add CKV_OPENAPI_7 for openAPI feat(openapi): add CKV_OPENAPI_7 to ensure http is not used in path definition Sep 21, 2022
gruebel
gruebel reviewed Sep 21, 2022
View reviewed changes
Copy link
Contributor

@gruebel gruebel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

great work 🍺 please also check the other failing checks.

checkov/openapi/checks/resource/v2/PathSchemeDefineHTTP.py Outdated Show resolved Hide resolved
gruebel
gruebel approved these changes Sep 22, 2022
View reviewed changes
Copy link
Contributor

@gruebel gruebel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice work 🚀

@marynaKK marynaKK merged commit b102340 into master Sep 28, 2022
@marynaKK marynaKK deleted the add-openAPI-check branch September 28, 2022 06:23
losisin pushed a commit to ignite-analytics/checkov that referenced this pull request Sep 28, 2022
@marynaKK @schosterbarak
feat(openapi): add CKV_OPENAPI_7 to ensure http is not used in path d…
1deb9a6 
…efinition (bridgecrewio#3547)

* added new openapi check PathSchemeDefineHTTP

* fix bugs

* change to Anton's suggections
losisin pushed a commit to ignite-analytics/checkov that referenced this pull request Sep 28, 2022
@marynaKK @schosterbarak
feat(openapi): add CKV_OPENAPI_7 to ensure http is not used in path d…
d991e8f 
…efinition (bridgecrewio#3547)

* added new openapi check PathSchemeDefineHTTP

* fix bugs

* change to Anton's suggections
losisin pushed a commit to ignite-analytics/checkov that referenced this pull request Sep 28, 2022
@marynaKK
feat(openapi): add CKV_OPENAPI_7 to ensure http is not used in path d…
3364042 
…efinition (bridgecrewio#3547)

* added new openapi check PathSchemeDefineHTTP

* fix bugs

* change to Anton's suggections
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gruebel gruebel gruebel approved these changes

@maxamel maxamel maxamel approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add check for OpenAPI for schemes using http
3 participants
@marynaKK @maxamel @gruebel