fix(general): handle fixes for cloned OOTB policies #3535
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mikeurbanski1
changed the title
rotemavni
approved these changes
Sep 20, 2022
achiar99
pushed a commit
that referenced
this pull request
Sep 20, 2022
* handle fixes for cloned OOTB policies * add mypy skip * make ckv_id explicitly not none to be safe * Update tests/common/integration_features/test_fixes_integration.py Co-authored-by: Anton Grübel <[email protected]> Co-authored-by: Anton Grübel <[email protected]>
achiar99
pushed a commit
that referenced
this pull request
Sep 20, 2022
* handle fixes for cloned OOTB policies * add mypy skip * make ckv_id explicitly not none to be safe * Update tests/common/integration_features/test_fixes_integration.py Co-authored-by: Anton Grübel <[email protected]> Co-authored-by: Anton Grübel <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
Description
Handles a case where fixes get returned with a custom policy ID, when an OOTB fixable policy is cloned. Checkov would fail to map them to the correct record, and logged an error message. This also resulted in the IDE extensions thinking the scan failed.
This fixes the core issue and also logs the actual error, if it occurs, at a lower level, because it does not break the overall scan.
Checklist: