Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(terraform): fix tfvars rendering #3533

Merged
merged 12 commits into from
Sep 20, 2022
Merged

fix(terraform): fix tfvars rendering #3533

merged 12 commits into from
Sep 20, 2022

Conversation

achiar99
Copy link
Contributor

@achiar99 achiar99 commented Sep 19, 2022

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Description

Fix tfvars rendering objects when refer to variables vertex

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my feature, policy, or fix is effective and works
  • New and existing tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@achiar99 achiar99 marked this pull request as draft September 19, 2022 12:41
@achiar99 achiar99 changed the title fix tfvars render fix(terraform): fix tfvars rendering Sep 19, 2022
@achiar99 achiar99 marked this pull request as ready for review September 20, 2022 12:04
Copy link
Collaborator

@rotemavni rotemavni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice!

@@ -172,3 +172,4 @@ tests/20*
# vim
.vim/
.vimspector.json
!tests/terraform/graph/variable_rendering/test_resources/tfvar_module_variables/modules/instance
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why?

Copy link
Contributor Author

@achiar99 achiar99 Sep 20, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i couldnt upload this folder to git because of this -

# Flask stuff:
instance/
.webassets-cache

@achiar99 achiar99 merged commit 4c0e1a5 into master Sep 20, 2022
@achiar99 achiar99 deleted the fix-tfvars-render branch September 20, 2022 12:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants