Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(terraform): make test case insensitive for CKV_ALI_35,CKV_ALI_36,CKV_ALI_37 #3507

Merged
merged 2 commits into from
Sep 18, 2022

Conversation

JamesWoolfenden
Copy link
Contributor

@JamesWoolfenden JamesWoolfenden commented Sep 14, 2022

Just made the base class use to lower case.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Description

Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.

Fixes # (issue)

New/Edited policies (Delete if not relevant)

Description

Include a description of what makes it a violation and any relevant external links.

Fix

How does someone fix the issue in code and/or in runtime?

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my feature, policy, or fix is effective and works
  • New and existing tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@gruebel gruebel changed the title fix(terraform): make test case insensitive for CKV_ALI_35,CKV_ALI_36,CKV_ALI_37 #3448 fix(terraform): make test case insensitive for CKV_ALI_35,CKV_ALI_36,CKV_ALI_37 Sep 14, 2022
Copy link
Contributor

@gruebel gruebel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯

@gruebel
Copy link
Contributor

gruebel commented Sep 14, 2022

@JamesWoolfenden can you add one test case for one of the checks?

@JamesWoolfenden
Copy link
Contributor Author

added test

@gruebel gruebel merged commit b4e9234 into master Sep 18, 2022
@gruebel gruebel deleted the fix/casesensitive branch September 18, 2022 15:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CKV_ALI_35,CKV_ALI_36,CKV_ALI_37:some parameters value of 'alicloud_db_instance' must be Lowercase letters
3 participants