fix(sca): skip old CVE suppressions (without 'accountIds') #3503
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ayajbara
reviewed
Sep 13, 2022
checkov/common/bridgecrew/integration_features/features/suppressions_integration.py
Outdated
Show resolved
Hide resolved
NoaAzoulay
changed the title
ayajbara
reviewed
Sep 13, 2022
checkov/common/bridgecrew/integration_features/features/suppressions_integration.py
Outdated
Show resolved
Hide resolved
ayajbara
reviewed
Sep 13, 2022
| if record.vulnerability_details and record.vulnerability_details['id'] == cve['cve']: | ||
| return True | ||
| return False | ||
| return any(record.vulnerability_details and record.vulnerability_details['id'] == cve['cve'] |
ayajbara
approved these changes
Sep 13, 2022
Saarett
requested changes
Sep 13, 2022
checkov/common/bridgecrew/integration_features/features/suppressions_integration.py
Outdated
Show resolved
Hide resolved
| if record.vulnerability_details and record.vulnerability_details['id'] == cve['cve']: | ||
| return True | ||
| return False | ||
| return any(record.vulnerability_details and record.vulnerability_details['id'] == cve['cve'] |
NoaAzoulay
changed the title
Saarett
approved these changes
Sep 14, 2022
nijdarshan
pushed a commit
to nijdarshan/checkov
that referenced
this pull request
Sep 15, 2022
…wio#3503) * skip old suppressions (without 'accountIds') + tests * skip old suppressions (without 'accountIds') + tests * /
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
Description
Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.
Fixes # (issue)
New/Edited policies (Delete if not relevant)
Description
Include a description of what makes it a violation and any relevant external links.
Fix
How does someone fix the issue in code and/or in runtime?
Checklist: