fix(sca): changes on cve suppressions to match package and image scan #3502
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gruebel
changed the title
# Conflicts: # checkov/common/bridgecrew/integration_features/features/suppressions_integration.py
itai1357
approved these changes
Sep 19, 2022
itai1357
reviewed
Sep 19, 2022
| for cve in suppression['cves']) | ||
| if self.bc_integration.repo_id in suppression['accountIds']: | ||
| repo_name = self.bc_integration.repo_id.replace('\\', '/').split('/')[-1] # type: ignore | ||
| suppression_path = suppression['cves'][0]['id'].replace('\\', '/') |
There was a problem hiding this comment.
I know you just moved it here, but do you know why we use only the index 0 of suppression['cves']?
in some cases (specifically in the UTs) there are more than 1 items in the list
There was a problem hiding this comment.
true, there can be more than one cve, but each suppression represent one file, so if we have few cves that were suppressed for the same file, the 'id' which is the file path will be the same for all of them
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
Description
Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.
Fixes # (issue)
New/Edited policies (Delete if not relevant)
Description
Include a description of what makes it a violation and any relevant external links.
Fix
How does someone fix the issue in code and/or in runtime?
Checklist: