-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(general): add flag for summary position #3497
Conversation
Very nice @marynaKK ! |
@arielkru You make sense :) I thought to preserve the current behavior, the flag default is top, and if it is used the summary moves to the bottom. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is there a test for this @marynaKK ? If not - can we write one?
if we change the default behaviour, then we should mark this PR as a breaking change -> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No tests in that area then... Only update the docs:
# CLI Command Reference |
@gruebel This is not a breaking change, only if you set the arg do you get a different behavior
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nice, great job on the first PR 💪
@nimrodkor that's why I wrote, if we change the default behaviour 🙂 if we don't, we don't need 😄 |
@gruebel Your suggestion is more clear - I'll keep it in mind to keep things simpler :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
great work ☕ 🍰
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
Description
Fixes #3222
Description
Added a flag to enable changing the summary position within the report. Default behavior didn't change - summary at the top. adding the flag --summary-position-bottom will move it to the bottom.
Checklist: