Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(gha): Gracefully handle bad GHA job definitions #3489

Merged
merged 2 commits into from
Sep 8, 2022

Conversation

nimrodkor
Copy link
Contributor

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Description

Allow GHA checks to gracefully handle bad job definitions.
Also add GHA to the PR title check

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my feature, policy, or fix is effective and works
  • New and existing tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@Eliran-Turgeman
Copy link
Contributor

Instead of adding safety measures inside the checks, can we apply it as a rule for the schema validation? (checkov/github_actions/schema_validator.py)

@nimrodkor
Copy link
Contributor Author

@Eliran-Turgeman Tried that, didn't have much luck 😓

@nimrodkor nimrodkor merged commit e49d230 into master Sep 8, 2022
@nimrodkor nimrodkor deleted the handle_bad_jobs_gracefully branch September 8, 2022 09:28
gruebel pushed a commit to gruebel/checkov that referenced this pull request Sep 8, 2022
* Gracefully handle bad GHA job definitions

* Add gha to allowed prefixes
gruebel pushed a commit to gruebel/checkov that referenced this pull request Sep 8, 2022
* Gracefully handle bad GHA job definitions

* Add gha to allowed prefixes
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants