feat(general): intersects/not_intersects operators (solvers)
#3482
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kadoshms
changed the title
intersects/not_intersects operators (solvers)intersects/not_intersects operators (solvers)
gruebel
reviewed
Sep 7, 2022
checkov/common/checks_infra/solvers/attribute_solvers/intersects_attribute_solver.py
Outdated
Show resolved
Hide resolved
checkov/common/checks_infra/solvers/attribute_solvers/not_intersects_attribute_solver.py
Outdated
Show resolved
Hide resolved
checkov/common/checks_infra/solvers/attribute_solvers/intersects_attribute_solver.py
Outdated
Show resolved
Hide resolved
checkov/common/checks_infra/solvers/attribute_solvers/intersects_attribute_solver.py
Show resolved
Hide resolved
nimrodkor
approved these changes
Sep 8, 2022
checkov/common/checks_infra/solvers/attribute_solvers/intersects_attribute_solver.py
Show resolved
Hide resolved
gruebel
pushed a commit
to gruebel/checkov
that referenced
this pull request
Sep 8, 2022
…ecrewio#3482) * feat: support for intersects/not_intersects solvers * fix: fixed mypy tests * chore: CR comments - removed logging, use Collection as type assertion Co-authored-by: Mor Kadosh <[email protected]>
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
Description
Introducing 2 new operators -
intersectsandnot_intersectsoperators, that given 2 values, check if those values intersect.Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.
Fixes # (issue)
New/Edited policies (Delete if not relevant)
Description
Include a description of what makes it a violation and any relevant external links.
Fix
How does someone fix the issue in code and/or in runtime?
Checklist: