Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

platform(sca): Add images data to image_cached_results for ImageReferencer scan #3468

Merged
merged 7 commits into from
Sep 6, 2022
Merged

platform(sca): Add images data to image_cached_results for ImageReferencer scan #3468

merged 7 commits into from
Sep 6, 2022

Conversation

ChanochShayner
Copy link
Contributor

@ChanochShayner ChanochShayner commented Sep 5, 2022 •
edited
Loading

Description

Add images data to image_cached_results for ImageReferencer scan

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my feature, policy, or fix is effective and works
  • New and existing tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@ChanochShayner ChanochShayner changed the title platform(ImageReferencer): Add images data to image_cached_results for ImageReferencer scan platform(SCA): Add images data to image_cached_results for ImageReferencer scan Sep 5, 2022
@ChanochShayner ChanochShayner changed the title platform(SCA): Add images data to image_cached_results for ImageReferencer scan platform(sca): Add images data to image_cached_results for ImageReferencer scan Sep 5, 2022
gruebel
gruebel approved these changes Sep 5, 2022
View reviewed changes
Copy link
Contributor

@gruebel gruebel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice job, happy to see it was not too much work to add it 😄

checkov/common/images/image_referencer.py Outdated Show resolved Hide resolved
rotemavni
rotemavni approved these changes Sep 6, 2022
View reviewed changes
checkov/common/images/image_referencer.py Outdated Show resolved Hide resolved
@ChanochShayner ChanochShayner merged commit 297f946 into master Sep 6, 2022
@ChanochShayner ChanochShayner deleted the SddImagesToImageCachedResults branch September 6, 2022 10:01
gruebel pushed a commit to gruebel/checkov that referenced this pull request Sep 6, 2022
@ChanochShayner @schosterbarak
platform(sca): Add images data to image_cached_results for ImageRefer…
101d894 
…encer scan (bridgecrewio#3468)

* Add image_cached_results for ImageReferencer scan

* UTs fixes

* UT fix

* Move import

* typing

* Naming
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rotemavni rotemavni rotemavni approved these changes

@gruebel gruebel gruebel approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ChanochShayner @gruebel @rotemavni