Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(cloudformation): json parser support triple quote string #3463

Merged
merged 4 commits into from
Sep 5, 2022
Merged

feat(cloudformation): json parser support triple quote string #3463

merged 4 commits into from
Sep 5, 2022

Conversation

achiar99
Copy link
Contributor

@achiar99 achiar99 commented Sep 4, 2022 •
edited
Loading

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Description

Support triple quotes string in json parser

Fixes # (issue)

New/Edited policies (Delete if not relevant)

Description

Include a description of what makes it a violation and any relevant external links.

Fix

How does someone fix the issue in code and/or in runtime?

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my feature, policy, or fix is effective and works
  • New and existing tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@achiar99 achiar99 changed the title json parser support triple quote string feat(json) - json parser support triple quote string Sep 4, 2022
@achiar99 achiar99 changed the title feat(json) - json parser support triple quote string feat(json): json parser support triple quote string Sep 4, 2022
@achiar99 achiar99 changed the title feat(json): json parser support triple quote string feat(cloudformation): json parser support triple quote string Sep 4, 2022
nimrodkor
nimrodkor reviewed Sep 4, 2022
View reviewed changes
Copy link
Contributor

@nimrodkor nimrodkor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! UT please @achiar99

checkov/common/parsers/json/decoder.py Outdated Show resolved Hide resolved
@achiar99 achiar99 marked this pull request as draft September 4, 2022 12:50
@achiar99 achiar99 marked this pull request as ready for review September 4, 2022 12:57
@achiar99 achiar99 requested a review from nimrodkor September 4, 2022 13:00
@achiar99 achiar99 merged commit d3bc03b into master Sep 5, 2022
@achiar99 achiar99 deleted the json-triple-quotes-parser branch September 5, 2022 05:26
losisin pushed a commit to ignite-analytics/checkov that referenced this pull request Sep 5, 2022
@achiar99 @schosterbarak
feat(cloudformation): json parser support triple quote string (bridge…
d931f8b 
…crewio#3463)

* json parser support triple quote string

* fix condition

* remove

* add UT
losisin pushed a commit to ignite-analytics/checkov that referenced this pull request Sep 5, 2022
@achiar99
feat(cloudformation): json parser support triple quote string (bridge…
90c2d24 
…crewio#3463)

* json parser support triple quote string

* fix condition

* remove

* add UT
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@YaaraVerner YaaraVerner YaaraVerner approved these changes

@tronxd tronxd tronxd approved these changes

@nimrodkor nimrodkor Awaiting requested review from nimrodkor

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@achiar99 @tronxd @nimrodkor @YaaraVerner