Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

platform(general): upload run metadata to S3 #3461

Merged
merged 7 commits into from
Sep 15, 2022
Merged

platform(general): upload run metadata to S3 #3461

merged 7 commits into from
Sep 15, 2022

Conversation

mikeurbanski1
Copy link
Contributor

@mikeurbanski1 mikeurbanski1 commented Sep 2, 2022 •
edited
Loading

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Description

Uploads the run metadata (same as gets printed to the debug logs) to S3 to make troubleshooting easier.

  • Checkov version
  • Python version
  • Executable locations
  • CLI args, environment variables, and config file args (API key is sanitized)

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my feature, policy, or fix is effective and works
  • New and existing tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@mikeurbanski1 mikeurbanski1 changed the title upload run metadata to S3 platform(general): upload run metadata to S3 Sep 2, 2022
nimrodkor
nimrodkor reviewed Sep 14, 2022
View reviewed changes
checkov/main.py Outdated Show resolved Hide resolved
gruebel
gruebel approved these changes Sep 14, 2022
View reviewed changes
Copy link
Contributor

@gruebel gruebel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I also fixed the mypy issue

@mikeurbanski1 @nimrodkor
Update checkov/main.py
1b19813 
Co-authored-by: Nimrod Kor <[email protected]>
@mikeurbanski1 mikeurbanski1 merged commit d626eee into master Sep 15, 2022
@mikeurbanski1 mikeurbanski1 deleted the include-run-command-in-results branch September 15, 2022 13:33
nijdarshan pushed a commit to nijdarshan/checkov that referenced this pull request Sep 16, 2022
@mikeurbanski1 @gruebel
@nimrodkor @schosterbarak
platform(general): upload run metadata to S3 (bridgecrewio#3461)
764c093 
* upload run metadata to S3

* fix typo

* upload run metadata as json

* sanitize API key on --show-config

* fix mypy

* Update checkov/main.py

Co-authored-by: Nimrod Kor <[email protected]>

Co-authored-by: gruebel <[email protected]>
Co-authored-by: Nimrod Kor <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gruebel gruebel gruebel approved these changes

@nimrodkor nimrodkor nimrodkor approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mikeurbanski1 @nimrodkor @gruebel