Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(terraform): gcp postgresql default values #3457

Merged

Conversation

losisin
Copy link
Contributor

@losisin losisin commented Sep 2, 2022

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Description

Fix checks when using default (undeclared) settings from GCP.

Fixes #3323

Edited policies

CKV_GCP_51, CKV_GCP_52, CKV_GCP_53 and CKV_GCP_54.

Description

When scanning terraform plan with checkov and running infrastructure with something like steampipe, result should match. Here is a list of all available PostgreSQL database flags with their respective default values: https://cloud.google.com/sql/docs/postgres/flags#list-flags-postgres

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my feature, policy, or fix is effective and works
  • New and existing tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

Copy link
Contributor

@gruebel gruebel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

in general looks good, just need to fix the tests and then it is ready to be merged 🚀

@losisin losisin requested a review from gruebel September 4, 2022 15:04
Copy link
Contributor

@gruebel gruebel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice, great job 🥇

@gruebel gruebel merged commit 1a5a542 into bridgecrewio:master Sep 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

GoogleCloudPostgreSql checks falsely pass when not declared at all
3 participants