Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(sca): Added fix details to junitxml #3456

Merged
merged 7 commits into from
Sep 2, 2022
Merged

feat(sca): Added fix details to junitxml #3456

merged 7 commits into from
Sep 2, 2022

Conversation

eurogig
Copy link
Contributor

@eurogig eurogig commented Sep 2, 2022

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Description

Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.]
Added details of the fix for the sca_package framework to the junitxml output format. Needed for platforms like AWS CodeBuild where the details would be viewed via the junitxml reporting format.

Fixes # (issue)

New/Edited policies (Delete if not relevant)

Description

Include a description of what makes it a violation and any relevant external links.

Fix

How does someone fix the issue in code and/or in runtime?

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my feature, policy, or fix is effective and works
  • New and existing tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@eurogig eurogig requested a review from gruebel September 2, 2022 11:46
@eurogig eurogig changed the title Added fix details to junitxml -fix Feat-Added fix details to junitxml Sep 2, 2022
@eurogig eurogig changed the title Feat-Added fix details to junitxml feat(sca_package): Added fix details to junitxml Sep 2, 2022
@eurogig eurogig requested a review from metahertz September 2, 2022 11:54
@eurogig eurogig changed the title feat(sca_package): Added fix details to junitxml feat(sca): Added fix details to junitxml Sep 2, 2022
Copy link
Contributor

@gruebel gruebel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🍺

checkov/common/output/report.py Outdated Show resolved Hide resolved
@gruebel gruebel merged commit a57f401 into bridgecrewio:master Sep 2, 2022
gruebel added a commit to gruebel/checkov that referenced this pull request Sep 2, 2022
* added fix details to junitxml

* removed 2nd link detail reference

* Changed text output expectation

* Adjustment to test output

* Update checkov/common/output/report.py

Co-authored-by: Anton Grübel <[email protected]>

* minor changes to testing

Co-authored-by: Anton Grübel <[email protected]>
itai1357 pushed a commit that referenced this pull request Sep 4, 2022
* added fix details to junitxml

* removed 2nd link detail reference

* Changed text output expectation

* Adjustment to test output

* Update checkov/common/output/report.py

Co-authored-by: Anton Grübel <[email protected]>

* minor changes to testing

Co-authored-by: Anton Grübel <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants