Iciclegraph and Flamegraph #89
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
bric3
commented
Jul 26, 2022
bric3
commented
The current place is actually an icicle view, this PR introduces an actual Flamegraph mode. Fixes #22
Removes the need of passing JViewport, instead relying on component location. Refs: #22
Before this change, the visible rect was taller because the horizontal scrollbar wasn't visible since the canvas had the same width as the visible rect. But zooming increases the canvas size which triggers the visibility of the scrollbar.
This changes the behavior of the scrollback button to go * upward when the mode is iciclegraph * downward when the mode is flamegraph Refs: #22
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.