refactor(flamegraph)!: Color function now takes a framebox #55
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
❌ Java CI with Gradle failed: https://gradle.com/s/7cdnjvd5gxei2 |
BREAKING CHANGE: Signature change on the color function
bric3
force-pushed
the
break-color-mapping
branch
from
294ba8d to
69ac60c
Compare
This component is embedded in a JLayer, however it's LayerUI doesn't paint background. In order to enable consumer to tweak the background, this change introduce a dumb JPanel wrapper that will forward the color to contributing component.
|
❌ Java CI with Gradle failed: https://gradle.com/s/janyo43kpgmma |
Introduce another method, and keep the old one.
bric3
force-pushed
the
break-color-mapping
branch
from
446391f to
8b06b01
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In order to be more flexible in regard of the frame coloring, this PR change the signature of the function callback to get the color from a frame.