Introduce custom viewport layout to fix container shrinking #149
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Custom layout code to handle container shrinking. The default view port layout asks the preferred size of the view. But that cannot work since the canvas won;t update its width, it receives its size from the layout container. However, the default algorithm only updates the size after it has received the preferred size, or if the viewport got bigger. This code makes the necessary query to the canvas to asks if it needs a new size given the viewport width change, in order to keep the same zoom factor. The view location is also updated. Fixes #46
|
Due to computation, the zoom factor is not stable. And thus I believe a proper |
This was referenced Jan 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Customize the viewport layout code to handle container shrinking. The default viewport layout asks the preferred size of the view. But that cannot work since the canvas won't update
its width, it receives its size from the layout container.
The default algorithm only updates the size after it has received the preferred size, or if the viewport got bigger.
This code makes the necessary query to the canvas to asks if it needs a new size given the viewport width change, in order to keep the same zoom factor.
The view location is also updated.
Fixes #46