-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
API to save a flamegraph as an image #100
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Implements basic save functionality from the FlamegraphView. But possible move to a different facade, so it can be called without creating components. Also: * Fixed off by 1 error, the deepest depth couldn't be painted * Removed Insets as unused * Cache depth computation in week hash map, based on integer (see docs) * Bug in FrameBox computation where the end of a node might be higher than 1.0 Fixes: #99
Only canvas width matter. The mechanism has been replaced by the weak hash map.
Also: * Added alpha channel detection Refs: #99
This overload allow to use different Graphics2D implementations or configurations, e.g the ones from Apache Batik (ASL2), JFreeSVG (GPL3) that are able to generate an SVG file. Refs: #99
❌ Java CI with Gradle failed: https://gradle.com/s/vl64he2634jqo |
❌ Java CI with Gradle failed: |
1 similar comment
❌ Java CI with Gradle failed: |
❌ Java CI with Gradle failed: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #99