Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

API to save a flamegraph as an image #100

Merged
merged 9 commits into from
Aug 3, 2022
Merged

API to save a flamegraph as an image #100

merged 9 commits into from
Aug 3, 2022

Conversation

bric3
Copy link
Owner

@bric3 bric3 commented Aug 3, 2022

Fixes #99

bric3 added 6 commits August 3, 2022 10:41
Implements basic save functionality from the FlamegraphView.
But possible move to a different facade, so it can be called without
creating components.

Also:
* Fixed off by 1 error, the deepest depth couldn't be painted
* Removed Insets as unused
* Cache depth computation in week hash map, based on integer (see docs)
* Bug in FrameBox computation where the end of a node might be higher
  than 1.0

Fixes: #99
Only canvas width matter. The mechanism has been replaced by the
weak hash map.
Also:
* Added alpha channel detection

Refs: #99
This overload allow to use different Graphics2D implementations or
configurations, e.g the ones from Apache Batik (ASL2), JFreeSVG (GPL3)
that are able to generate an SVG file.

Refs: #99
@github-actions
Copy link

github-actions bot commented Aug 3, 2022

❌ Java CI with Gradle failed: https://gradle.com/s/vl64he2634jqo

@github-actions
Copy link

github-actions bot commented Aug 3, 2022

❌ Java CI with Gradle failed:

1 similar comment
@github-actions
Copy link

github-actions bot commented Aug 3, 2022

❌ Java CI with Gradle failed:

@github-actions
Copy link

github-actions bot commented Aug 3, 2022

❌ Java CI with Gradle failed:

@bric3 bric3 merged commit 26231d1 into master Aug 3, 2022
@bric3 bric3 deleted the save branch August 3, 2022 16:47
@bric3 bric3 added the enhancement New feature or request label Dec 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Ability to generate an image
1 participant