Let user know which tags are missing per run (#967) #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some early users of margin plots noticed a bug. If data associated with a tag for any run was missing, an error message appeared noting that data was missing for that tag. The error message gave no indication of which runs were missing information. Sometimes, the behavior is intended. For instance, some run might not log a certain scalar value. This change now offers users a more nuanced message when margin plot logic is missing information for certain tags within a run. The message notes specific runs and then lists the specific tags without data for those runs. The message is placed under a collapsible so that the user can chose to not see the message if the behavior is intended. Messages are only shown if a run is missing data for some but not all tags.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some early users of margin plots noticed a bug. If data associated with
a tag for any run was missing, an error message appeared noting that
data was missing for that tag. The error message gave no indication of
which runs were missing information. Sometimes, the behavior is
intended. For instance, some run might not log a certain scalar value.
This change now offers users a more nuanced message when margin plot
logic is missing information for certain tags within a run. The message
notes specific runs and then lists the specific tags without data for
those runs. The message is placed under a collapsible so that the user
can chose to not see the message if the behavior is intended. Messages
are only shown if a run is missing data for some but not all tags.