Permit trusted self-signed certificates #170
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #170 +/- ##
==========================================
+ Coverage 73.91% 74.20% +0.28%
==========================================
Files 14 14
Lines 1357 1380 +23
==========================================
+ Hits 1003 1024 +21
- Misses 354 356 +2
Continue to review full report at Codecov.
|
Ichbinjoe
force-pushed
the
selfsigned
branch
3 times, most recently
from
c382e92 to
6c4f081
Compare
Self-signed certificates are both an end-entity as well as a certificate authority in the eyes of webpki - since we have ultimate trust in the supplied trust anchors, a certificate supplied with the same subject as a trust anchor and is directly signed by the same trust anchor should also be valid, even though the certificate supplied might still be a CA.
|
Thank you. Please see #114 (comment) to understand why I'm closing this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Self-signed certificates are both an end-entity as well as a certificate
authority in the eyes of webpki - since we have ultimate trust in the
supplied trust anchors, a certificate supplied with the same subject as a
trust anchor and is directly signed by the same trust anchor should also
be valid, even though the certificate supplied might still be a CA.
Alternate to #127 and fixes #114. Unlike #127, this change has no public facing API change and doesn't require marking certain certificates as explicitly self-signed.