Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Right now,
src/lib.rs
defines ring to be ano_std
crate conditionally based on the features and CPU architecture. This is sub-optimal, as it requires a lot ofcfg
attributes to be kept in sync. Bothrand
andrdrand
have dealt with this kind of problem, and they use the following solution.#![no_std]
std
is needed, it can be brought in withextern crate std
use std
oruse core
statements (as they are never necessary)This is what I did in this PR. Some advantages to this PR:
std
. This helps with:no_std
-only platform #744no_std
extern crate alloc
lands in the next stable Rust release, most of theuse std::
statements can be turned intouse alloc::
.use_heap
feature into two featuresstd
: Enables getting randomness from files andstd::error::Error
implementationsalloc
: Enables operations that need dynamic memory allocation (RSA signing, etc...)