Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve Travis CI Android Builds #548

Closed
wants to merge 7 commits into from

Conversation

pietro
Copy link
Contributor

@pietro pietro commented May 27, 2017

This PR improves the Android situation on Travis CI. It caches some of the Android things we need to download for every build and adds AArch64 builds. It fixes both #486 and the issue I wrote about on #518.

@ghost
Copy link

ghost commented May 27, 2017

Can't find anything malicious in the changes.

@briansmith
Copy link
Owner

Thanks a ton for this!

I rebased these changes and pushed them (otherwise unmodified) to master:

52c645b Don't install unnecessary packages on Travis CI Android builds.
b7073f4 Cache Android NDK, tools and platform tools on Travis CI.
06da374 Add support to install different Android system images on Travis CI.
759f1cc Define Android API level needed for AArch64.
cd011b3 Add AArch64 to Travis CI builds.
ffe7e97 Use travis_wait on all Android release builds on Travis CI.
4388505 Add AArch64 build info to README.

@briansmith briansmith closed this Jun 8, 2017
@pietro
Copy link
Contributor Author

pietro commented Jun 8, 2017

Cool! Hopefully next week I'll have time to debug the 32-bit ARM issues when using clang.

@briansmith
Copy link
Owner

@pietro After this change some builds are failing with "No space left on device": https://travis-ci.org/briansmith/ring/jobs/240986948

@briansmith briansmith reopened this Jun 10, 2017
@coveralls
Copy link

coveralls commented Jun 10, 2017

Coverage Status

Coverage decreased (-0.07%) to 95.859% when pulling b99358d on pietro:travis_android into 2db042d on briansmith:master.

@briansmith
Copy link
Owner

@pietro I had to revert these changes due to the build failures. Not sure what we can do. Maybe we can delete intermediate inputs after the input has been used and is no longer needed. And/or maybe when we need to rebuild a cached file, we should delete all the prevously- (stale) cached files before attempting the rebuild?

@briansmith
Copy link
Owner

I'm going to close this PR in favor of switching to cross for building and testing Android. Thanks for all your contributions here!

@briansmith briansmith closed this Dec 16, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants