-
-
Notifications
You must be signed in to change notification settings - Fork 188
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CPU usage management #48
Comments
Right now calculations happen when you open a note, and the results are cached during the session. I suppose those caches can could persist after you close Obsidian, but that would risk serving outdated results. Another possibility is selectively persisting the cache. And as I'm typing, I think the caching mechanism might need to be updated since updating the results to include snippets. These snippets may not be cached, causing unnecessary file reads. I'll take a deeper look into this. Thanks for bringing the issue to my attention @franciscoabenza |
I recommend a caching mechanism that runs a checksum and checks the mod time of the opened note. If the Checksum didn't change and the mod time didn't, in theory it should be feasible to automatically detect when to persist the cache. I'd look into a good, but performant checksum algorithm for JavaScript |
@smartguy1196 Thanks for suggestion. Those are already being used to determine when to re-embed. But using them as a caching trigger is a little trickier because the cache depends on other notes and not just the current note. It can be done, but it will take working through the necessary logic to make sure caches get expired appropriately. |
To be honest I don't know the cause of the CPU usage. All I know is that if
you open the activity monitor and try opening and closing the tab for this
plug-in you will see what I mean (please, test it as you may get a
different result). It took me some time to figure out why my fans were
going crazy if Obsidian was open. I hope this helps. I love this extension
so much. So many potential features by the way.
…On Tue, 7 Mar 2023 at 19:18, Brian Petro ***@***.***> wrote:
@smartguy1196 <https://github.com/smartguy1196> Thanks for suggestion.
Those are already being used to determine when to re-embed. But using them
as a caching trigger is a little trickier because the cache depends on
other notes and not just the current note. It can be done, but it will take
working through the necessary logic to make sure caches get expired
appropriately.
—
Reply to this email directly, view it on GitHub
<#48 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AFIHMRZ2RQ4SQO45QV5SILLW253WTANCNFSM6AAAAAAVSQUPSM>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
Did you have anything specific in mind for this? @franciscoabenza thanks for your help! |
Assisted structure within the notes. Something that helps me stay
consistent and takes care of the "meta-data" for me would be delightful.
Smart-dynamic templates sort sepak. Call it however you want: augmented,
assisted, aided, supported, enhanced - Zettelkasten system
…On Wed, 8 Mar 2023 at 13:38, Brian Petro ***@***.***> wrote:
So many potential features by the way.
Did you have anything specific in mind for this?
@franciscoabenza <https://github.com/franciscoabenza> thanks for your
help!
—
Reply to this email directly, view it on GitHub
<#48 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AFIHMRYX27ANPP4W7AXUVODW3B4V3ANCNFSM6AAAAAAVSQUPSM>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
@franciscoabenza I really like the way you are thinking. Would you mind elaborating a little more for me? I think you're on to something, and I might be able to make it happen. |
This is something quite close to my core and the type of software that I am working on (So I may be able to colab). If you want you can add yourself to my calendar (after the 16 March) and we can discuss it further. Book time, It doesn't have to be long :) |
@franciscoabenza Scheduled! Please don't hesitate to add any feature requests in the meantime. We could always use them as a basis for our chat. Looking forward to it. Thank you! |
Always good to see collaborative work! |
I don't know if anything changed but my CPU seem to have a reasonable use allocated :) so I am going to close this ;) |
Absolute hog for CPU.
Please let the user change how often is the cycle for calculating smart connections
The text was updated successfully, but these errors were encountered: