Correction of Months' Names In CKB language #2973
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Kyle <[email protected]>
Co-authored-by: Kyle <[email protected]>
kawan97
commented
Mar 19, 2024
|
Thank you, I'll update the tests and merge it. |
|
ok, i'm waiting. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Correction of Months' Names In CKB language
Issue: This pull request addresses an issue where the months' names are incorrect in the Carbon package for the CKB , I've taken the opportunity to update months name for accuracy and clarity.
Changes Made:
Reasoning: Accurate month names are crucial for applications relying on time-related functionalities. Furthermore, updating months name enhances the user experience and ensures clarity in the Carbon package.
Proposed Solution: I've made the necessary changes directly in the ckb source code files . Each change is accompanied by a clear and descriptive commit message detailing the nature of the modification.
Additional Notes: If there are any concerns or suggestions regarding these changes, please feel free to discuss them in the comments section of this pull request. I'm open to any feedback or further improvements.