Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

⭐ Create empty interval by default #2079

Closed
kylekatarnls opened this issue May 6, 2020 · 0 comments
Closed

⭐ Create empty interval by default #2079

kylekatarnls opened this issue May 6, 2020 · 0 comments
Assignees
@kylekatarnls
Labels
available on 3.x-dev Can yet be test requiring "nesbot/carbon": "3.x-dev" enhancement
Milestone
3.0.0

Comments

@kylekatarnls
Copy link
Collaborator

The following code:

echo CarbonInterval::create()->spec();

Carbon 2

P1Y

Carbon 3

PT0S

Since Carbon 3, CarbonInterval with no parameter will no longer be set as 1 year, but as empty interval (no time = 0 seconds).
@kylekatarnls kylekatarnls added this to the 3.0.0 milestone May 6, 2020
@kylekatarnls kylekatarnls self-assigned this May 6, 2020
kylekatarnls added a commit that referenced this issue May 6, 2020
@kylekatarnls
#2079 Create empty interval by default
145da9f
@kylekatarnls kylekatarnls mentioned this issue May 6, 2020
Open
@kylekatarnls kylekatarnls added the available on 3.x-dev Can yet be test requiring "nesbot/carbon": "3.x-dev" label May 17, 2020
@kylekatarnls kylekatarnls changed the title Create empty interval by default ⭐ Create empty interval by default Jul 23, 2020
@kylekatarnls kylekatarnls mentioned this issue Jan 22, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kylekatarnls kylekatarnls

Labels
available on 3.x-dev Can yet be test requiring "nesbot/carbon": "3.x-dev" enhancement
Projects
None yet
Milestone
3.0.0
Development

No branches or pull requests
1 participant
@kylekatarnls