Make overflow tests not sensitive to DST

briannesbitt · May 28, 2021 · 1f38f65 · 1f38f65
1 parent 534ac51
commit 1f38f65
Showing 1 changed file with 7 additions and 5 deletions.
diff --git a/tests/Carbon/SettersTest.php b/tests/Carbon/SettersTest.php
@@ -592,7 +592,9 @@ public function testSetUnitNoOverflow()
                 $date->$valueUnit === $modulo ||
                 $$valueUnit - ((int) $date->{"diffIn$unit"}($original, false)) === $value ||
                 ($valueUnit === 'day' &&
-                    $date->format('Y-m-d H:i:s.u') === $original->copy()->modify(($original->day + $value).' days'))
+                    $date->format('Y-m-d H:i:s.u') === $original->copy()
+                        ->modify(($original->day + $value).' days')
+                        ->format('Y-m-d H:i:s.u'))
             ) {
                 $results['current']++;
 
@@ -707,7 +709,7 @@ public function testAddUnitNoOverflow()
             if ($date->$valueUnit === $value ||
                 $date->$valueUnit === $modulo ||
                 (method_exists($date, "diffInReal$unit") && -$date->{"diffInReal$unit"}($original, false) === $value) ||
-                -((int) $date->{"diffIn$unit"}($original, false)) === $value
+                -((int) round($date->{"diffIn$unit"}($original, false))) === $value
             ) {
                 $results['current']++;
 
@@ -737,7 +739,7 @@ public function testAddUnitNoOverflow()
                 $overflowUnit,
                 $unit,
                 $modulo,
-                $$valueUnit,
+                $value,
             );
         }
 
@@ -804,7 +806,7 @@ public function testSubUnitNoOverflow()
             if ($date->$valueUnit === $value ||
                 $date->$valueUnit === $modulo ||
                 (method_exists($date, "diffInReal$unit") && $date->{"diffInReal$unit"}($original, false) === $value) ||
-                ((int) $date->{"diffIn$unit"}($original, false)) === $value
+                ((int) round($date->{"diffIn$unit"}($original, false))) === $value
             ) {
                 $results['current']++;
 
@@ -834,7 +836,7 @@ public function testSubUnitNoOverflow()
                 $overflowUnit,
                 $unit,
                 $modulo,
-                $$valueUnit,
+                $value,
             );
         }