Preserve hardlinks when recreating config/plugin folders #42
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi, I've found this issue when I was configuring some plugins like DiscordConnector and WebMap. These mods create persistent files that aren't preserved when Updating the Valheim setup or when installing new mods. (I asked about these issues in the Discord beforehand, same handle as here)
I tried to solve this by creating hardlinks to the newly created files inside the custom_config[_secure] and custom_plugins folders. The issue is, it works for the first time until the first reset. The container copies the files inside the custom folders, without preserving the hardlinks. This serves only as a "backup" until the next reset. I have to recreate the hardlinks each time I update the server.
I suggest this change, but I'm not UNIX-savvy and I don't know if it would create other issues when copying with -a instead of -p. Feel free to suggest any changes.